From 18983c00b4d2beafde6a6cfa64ec1cab042f682b Mon Sep 17 00:00:00 2001 From: CJ van den Berg Date: Wed, 17 Dec 2025 22:10:20 +0100 Subject: [PATCH] refactor: do not log git rev-parse errors --- src/git.zig | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/git.zig b/src/git.zig index a67cfd6..0330026 100644 --- a/src/git.zig +++ b/src/git.zig @@ -264,13 +264,13 @@ pub fn rev_parse(context_: usize, rev: []const u8, file_path: []const u8) Error! try arg.writer.print("{s}", .{rev}) else try arg.writer.print("{s}:{s}", .{ rev, file_path }); - try git_err(context_, .{ "rev-parse", arg.written() }, struct { + try git(context_, .{ "rev-parse", arg.written() }, struct { fn result(context: usize, parent: tp.pid_ref, output: []const u8) void { var it = std.mem.splitScalar(u8, output, '\n'); while (it.next()) |value| if (value.len > 0) parent.send(.{ module_name, context, tag, value }) catch {}; } - }.result, log_err, exit_null(tag)); + }.result, exit_null(tag)); } pub fn cat_file(context_: usize, object: []const u8) Error!void { @@ -310,8 +310,10 @@ fn git_err( ) Error!void { const cbor = @import("cbor"); const git_binary = get_git() orelse return error.GitNotFound; + var buf: std.Io.Writer.Allocating = .init(allocator); defer buf.deinit(); + const writer = &buf.writer; switch (@typeInfo(@TypeOf(cmd))) { .@"struct" => |info| if (info.is_tuple) {