neurocyte/flow
neurocyte/flow
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: use after free on fast project switching

Browse source
This commit is contained in:
CJ van den Berg 2025-01-17 21:13:47 +01:00
parent d2735a5dd7
commit 48efa5536f
Signed by: neurocyte
GPG key ID: 8EB1E1BB660E3FB9
1 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/tui/mainview.zig
View file

@ -810,6 +810,7 @@ fn delete_active_view(self: *Self) !void {
fn replace_active_view(self: *Self, widget: Widget) !void { fn replace_active_view(self: *Self, widget: Widget) !void {
const n = self.active_view orelse return error.NotFound; const n = self.active_view orelse return error.NotFound;
self.remove_editor(0);
self.views.replace(n, widget); self.views.replace(n, widget);
} }
@ -819,16 +820,13 @@ fn create_editor(self: *Self) !void {
command.executeName("enter_mode_default", .{}) catch {}; command.executeName("enter_mode_default", .{}) catch {};
var editor_widget = try ed.create(self.allocator, Widget.to(self)); var editor_widget = try ed.create(self.allocator, Widget.to(self));
errdefer editor_widget.deinit(self.allocator); errdefer editor_widget.deinit(self.allocator);
if (editor_widget.get("editor")) |editor| { const editor = editor_widget.get("editor") orelse @panic("mainview editor not found");
if (self.top_bar) |bar| editor.subscribe(EventHandler.to_unowned(bar)) catch @panic("subscribe unsupported"); if (self.top_bar) |bar| editor.subscribe(EventHandler.to_unowned(bar)) catch @panic("subscribe unsupported");
if (self.bottom_bar) |bar| editor.subscribe(EventHandler.to_unowned(bar)) catch @panic("subscribe unsupported"); if (self.bottom_bar) |bar| editor.subscribe(EventHandler.to_unowned(bar)) catch @panic("subscribe unsupported");
editor.subscribe(EventHandler.bind(self, handle_editor_event)) catch @panic("subscribe unsupported"); editor.subscribe(EventHandler.bind(self, handle_editor_event)) catch @panic("subscribe unsupported");
if (editor.dynamic_cast(ed.EditorWidget)) |p|
try self.add_editor(&p.editor)
else
self.remove_editor(0);
} else @panic("mainview editor not found");
try self.replace_active_view(editor_widget); try self.replace_active_view(editor_widget);
if (editor.dynamic_cast(ed.EditorWidget)) |p|
try self.add_editor(&p.editor);
tui.current().resize(); tui.current().resize();
} }