neurocyte/flow
neurocyte/flow
1
1
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

refactor: use @memcpy to splat replacement string

Browse source 
Also, don't leak replacement string.
This commit is contained in:
CJ van den Berg 2025-10-30 22:35:38 +01:00
parent 18bc89edf8
commit 63745f1e6b
1 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/tui/mode/helix.zig
View file

@ -625,12 +625,9 @@ fn replace_cursel_with_character(ed: *Editor, root: Buffer.Root, cursel: *CurSel
var sfa = std.heap.stackFallback(4096, ed.allocator); var sfa = std.heap.stackFallback(4096, ed.allocator);
const sfa_allocator = sfa.get(); const sfa_allocator = sfa.get();
const replacement = sfa_allocator.alloc(u8, total_length) catch return error.Stop; const replacement = sfa_allocator.alloc(u8, total_length) catch return error.Stop;
errdefer allocator.free(replacement); defer sfa_allocator.free(replacement);
for (0..sel_length) |i| { for (0..sel_length) |i|
for (0..egc.len) |j| { @memcpy(replacement[i * egc.len .. (i + 1) * egc.len], egc);
replacement[i * egc.len + j] = egc[j];
}
}
const root_ = insert_replace_selection(ed, root, cursel, replacement, allocator) catch return error.Stop; const root_ = insert_replace_selection(ed, root, cursel, replacement, allocator) catch return error.Stop;