From 7dab15da203340f463b0a8e9db6906daa0a26097 Mon Sep 17 00:00:00 2001 From: CJ van den Berg Date: Mon, 12 Jan 2026 19:16:01 +0100 Subject: [PATCH] refactor: merge loops in completion_palette.load_entries --- src/tui/mode/overlay/completion_palette.zig | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/tui/mode/overlay/completion_palette.zig b/src/tui/mode/overlay/completion_palette.zig index 73f4625..3e700ec 100644 --- a/src/tui/mode/overlay/completion_palette.zig +++ b/src/tui/mode/overlay/completion_palette.zig @@ -35,24 +35,25 @@ pub const defaultValue: ValueType = .{}; var max_description: usize = 0; pub fn load_entries(palette: *Type) !usize { + max_description = 0; + var max_label_len: usize = 0; + const editor = tui.get_active_editor() orelse return error.NotFound; palette.value.start = editor.get_primary().*; var iter: []const u8 = editor.completions.items; while (iter.len > 0) { var cbor_item: []const u8 = undefined; if (!try cbor.matchValue(&iter, cbor.extract_cbor(&cbor_item))) return error.BadCompletion; - (try palette.entries.addOne(palette.allocator)).* = .{ .cbor = cbor_item, .label = undefined, .sort_text = undefined }; - } - - max_description = 0; - var max_label_len: usize = 0; - for (palette.entries.items) |*item| { - const values = get_values(item.cbor); + const values = get_values(cbor_item); if (palette.value.replace == null) if (get_replace_selection(values.replace)) |replace| { palette.value.replace = replace; }; - item.label = values.label; - item.sort_text = values.sort_text; + const item = (try palette.entries.addOne(palette.allocator)); + item.* = .{ + .cbor = cbor_item, + .label = values.label, + .sort_text = values.sort_text, + }; var lines = std.mem.splitScalar(u8, values.label_description, '\n'); const label_description_len = if (lines.next()) |desc| desc.len else values.label_description.len;