neurocyte/flow
neurocyte/flow
1
1
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

fix: only update tabbar widgets if buffers have changed

Browse source
This commit is contained in:
CJ van den Berg 2026-01-15 19:53:40 +01:00
parent ff38c37df7
commit 8c6091c419
Signed by: neurocyte
GPG key ID: 8EB1E1BB660E3FB9
1 changed files with 13 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/tui/status/tabs.zig
View file

@ -232,7 +232,7 @@ pub const TabBar = struct {
fn update_tabs(self: *Self, drag_source: ?*Widget) !void { fn update_tabs(self: *Self, drag_source: ?*Widget) !void {
const buffer_manager = tui.get_buffer_manager() orelse @panic("tabs no buffer manager"); const buffer_manager = tui.get_buffer_manager() orelse @panic("tabs no buffer manager");
try self.update_tab_buffers(); if (!try self.update_tab_buffers()) return;
var prev_widget_count: usize = 0; var prev_widget_count: usize = 0;
for (self.widget_list.widgets.items) |*split_widgetstate| if (split_widgetstate.widget.dynamic_cast(WidgetList)) |split| { for (self.widget_list.widgets.items) |*split_widgetstate| if (split_widgetstate.widget.dynamic_cast(WidgetList)) |split| {
prev_widget_count += 1; prev_widget_count += 1;
@ -275,11 +275,11 @@ pub const TabBar = struct {
} }
} }
} }
if (prev_widget_count != self.widget_list.widgets.items.len) if (prev_widget_count != widget_count)
tui.refresh_hover(@src()); tui.refresh_hover(@src());
} }
fn update_tab_buffers(self: *Self) !void { fn update_tab_buffers(self: *Self) !bool {
const buffer_manager = tui.get_buffer_manager() orelse @panic("tabs no buffer manager"); const buffer_manager = tui.get_buffer_manager() orelse @panic("tabs no buffer manager");
const buffers = try buffer_manager.list_unordered(self.allocator); const buffers = try buffer_manager.list_unordered(self.allocator);
defer self.allocator.free(buffers); defer self.allocator.free(buffers);
@ -305,6 +305,16 @@ pub const TabBar = struct {
} }
self.tabs = try result.toOwnedSlice(self.allocator); self.tabs = try result.toOwnedSlice(self.allocator);
if (existing_tabs.len != self.tabs.len)
return true;
for (existing_tabs, self.tabs) |tab_a, tab_b| {
if (tab_a.buffer_ref == tab_b.buffer_ref and
tab_a.view == tab_b.view)
continue;
return true;
}
return false;
} }
fn place_new_tab(self: *Self, result: *std.ArrayListUnmanaged(TabBarTab), buffer: *Buffer) !void { fn place_new_tab(self: *Self, result: *std.ArrayListUnmanaged(TabBarTab), buffer: *Buffer) !void {