neurocyte/flow
neurocyte/flow
1
1
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

fix: completion dropdown must dupe completion data

Browse source 
Because it might be erased by the next completion response.

closes #477
This commit is contained in:
CJ van den Berg 2026-02-01 20:14:16 +01:00
parent d07389b8ee
commit a3ea183ba1
Signed by: neurocyte
GPG key ID: 8EB1E1BB660E3FB9
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/tui/mode/overlay/completion_dropdown.zig
View file

@ -36,6 +36,7 @@ pub const ValueType = struct {
query: ?Buffer.Selection = null, query: ?Buffer.Selection = null,
last_query: ?[]const u8 = null, last_query: ?[]const u8 = null,
commands: command.Collection(cmds) = undefined, commands: command.Collection(cmds) = undefined,
data: []const u8 = &.{},
}; };
pub const defaultValue: ValueType = .{}; pub const defaultValue: ValueType = .{};
@ -53,7 +54,9 @@ pub fn load_entries(self: *Type) !usize {
self.value.cursor = self.value.editor.get_primary().cursor; self.value.cursor = self.value.editor.get_primary().cursor;
self.value.query = null; self.value.query = null;
var iter: []const u8 = self.value.editor.completions.data.items; self.allocator.free(self.value.data);
self.value.data = try self.allocator.dupe(u8, self.value.editor.completions.data.items);
var iter: []const u8 = self.value.data;
while (iter.len > 0) { while (iter.len > 0) {
var cbor_item: []const u8 = undefined; var cbor_item: []const u8 = undefined;
if (!try cbor.matchValue(&iter, cbor.extract_cbor(&cbor_item))) return error.BadCompletion; if (!try cbor.matchValue(&iter, cbor.extract_cbor(&cbor_item))) return error.BadCompletion;
@ -90,6 +93,7 @@ pub fn load_entries(self: *Type) !usize {
} }
pub fn deinit(self: *Type) void { pub fn deinit(self: *Type) void {
self.allocator.free(self.value.data);
if (self.value.last_query) |p| self.allocator.free(p); if (self.value.last_query) |p| self.allocator.free(p);
self.value.commands.deinit(); self.value.commands.deinit();
} }