refactor: render gutter diffs only as insert or delete

This commit is contained in:
CJ van den Berg 2026-01-13 16:21:38 +01:00
parent 2d5288aa6f
commit a6b78397bf
Signed by: neurocyte
GPG key ID: 8EB1E1BB660E3FB9

View file

@ -40,7 +40,7 @@ diff_symbols: std.ArrayList(Symbol),
const Self = @This();
const Kind = enum { insert, modified, delete };
const Kind = enum { insert, delete };
const Symbol = struct { kind: Kind, line: usize };
pub fn create(allocator: Allocator, parent: Widget, event_source: Widget, editor: *ed.Editor) !Widget {
@ -259,23 +259,18 @@ inline fn render_diff_symbols(self: *Self, diff_symbols: *[]Symbol, pos: usize,
if ((diff_symbols.*)[0].line > linenum) return;
const sym = (diff_symbols.*)[0];
const kind: Kind = switch (sym.kind) {
.insert => .insert,
.modified => .insert, //TODO: we map .modified to .insert here because the diff algo is unstable
.delete => .delete,
};
const char = switch (kind) {
const char = switch (sym.kind) {
.insert => "",
.modified => "",
// .modified => "",
.delete => "",
};
self.plane.cursor_move_yx(@intCast(pos), @intCast(self.get_width() - 1)) catch return;
self.plane.cursor_move_yx(@intCast(pos), @intCast(self.get_width() - 1));
var cell = self.plane.cell_init();
_ = self.plane.at_cursor_cell(&cell) catch return;
cell.set_style_fg(switch (kind) {
cell.set_style_fg(switch (sym.kind) {
.insert => theme.editor_gutter_added,
.modified => theme.editor_gutter_modified,
// .modified => theme.editor_gutter_modified,
.delete => theme.editor_gutter_deleted,
});
_ = self.plane.cell_load(&cell, char) catch {};
@ -420,24 +415,25 @@ pub fn process_diff(self: *Self, cb: []const u8) MessageFilter.Error!void {
}
fn process_edit(self: *Self, kind: Kind, line: usize, offset: usize, bytes: []const u8) !void {
const change = if (self.diff_symbols.items.len > 0) self.diff_symbols.items[self.diff_symbols.items.len - 1].line == line else false;
if (change) {
self.diff_symbols.items[self.diff_symbols.items.len - 1].kind = .modified;
std.log.debug("edit: k:{} l:{d} off:{} bytes:\"{s}\"", .{ kind, line, offset, bytes });
if (self.diff_symbols.items.len > 0 and
self.diff_symbols.items[self.diff_symbols.items.len - 1].line == line)
{
self.diff_symbols.items[self.diff_symbols.items.len - 1].kind = .insert;
return;
}
(try self.diff_symbols.addOne(self.allocator)).* = switch (kind) {
const value: Symbol = switch (kind) {
.insert => ret: {
if (offset > 0)
break :ret .{ .kind = .modified, .line = line };
break :ret .{ .kind = .insert, .line = line };
if (bytes.len == 0)
return;
if (bytes[bytes.len - 1] == '\n')
break :ret .{ .kind = .insert, .line = line };
break :ret .{ .kind = .modified, .line = line };
break :ret .{ .kind = .insert, .line = line };
},
.delete => .{ .kind = .delete, .line = line },
else => unreachable,
};
(try self.diff_symbols.addOne(self.allocator)).* = value;
}
pub fn filter_receive(self: *Self, _: tp.pid_ref, m: tp.message) MessageFilter.Error!bool {