neurocyte/flow
neurocyte/flow
1
1
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

refactor: improve send_symbol error reporting

Browse source
This commit is contained in:
CJ van den Berg 2026-01-12 17:02:36 +01:00
parent bfd98c3b90
commit cf3648ce80
Signed by: neurocyte
GPG key ID: 8EB1E1BB660E3FB9
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/Project.zig
View file

@ -1312,7 +1312,7 @@ fn send_symbol_items(to: tp.pid_ref, file_path: []const u8, items: []const u8) (
var item: []const u8 = ""; var item: []const u8 = "";
var node_count: usize = 0; var node_count: usize = 0;
while (len > 0) : (len -= 1) { while (len > 0) : (len -= 1) {
if (!(try cbor.matchValue(&iter, cbor.extract_cbor(&item)))) return error.InvalidSymbolInformation; if (!(try cbor.matchValue(&iter, cbor.extract_cbor(&item)))) return error.InvalidSymbolInformationArray;
node_count += try send_symbol_information(to, file_path, item, ""); node_count += try send_symbol_information(to, file_path, item, "");
} }
return to.send(.{ "cmd", "add_document_symbol_done", .{file_path} }) catch |e| { return to.send(.{ "cmd", "add_document_symbol_done", .{file_path} }) catch |e| {
@ -1373,7 +1373,8 @@ fn invalid_symbol_information_field(field: []const u8) error{InvalidSymbolInform
} }
pub const SymbolInformationError = error{ pub const SymbolInformationError = error{
InvalidSymbolInformation, InvalidSymbolInformationFieldName,
InvalidSymbolInformationArray,
InvalidSymbolInformationField, InvalidSymbolInformationField,
InvalidTargetURI, InvalidTargetURI,
} || LocationLinkError || cbor.Error; } || LocationLinkError || cbor.Error;
@ -1397,7 +1398,7 @@ fn send_symbol_information(to: tp.pid_ref, file_path: []const u8, item: []const
tags[0] = 0; tags[0] = 0;
while (len > 0) : (len -= 1) { while (len > 0) : (len -= 1) {
var field_name: []const u8 = undefined; var field_name: []const u8 = undefined;
if (!(try cbor.matchString(&iter, &field_name))) return error.InvalidSymbolInformation; if (!(try cbor.matchString(&iter, &field_name))) return error.InvalidSymbolInformationFieldName;
if (std.mem.eql(u8, field_name, "name")) { if (std.mem.eql(u8, field_name, "name")) {
if (!(try cbor.matchValue(&iter, cbor.extract(&name)))) return invalid_symbol_information_field("name"); if (!(try cbor.matchValue(&iter, cbor.extract(&name)))) return invalid_symbol_information_field("name");
} else if (std.mem.eql(u8, field_name, "detail")) { } else if (std.mem.eql(u8, field_name, "detail")) {