From b99d0e57a6147df82e741f751c36ce57b478761a Mon Sep 17 00:00:00 2001 From: CJ van den Berg Date: Mon, 30 Mar 2026 21:55:35 +0200 Subject: [PATCH] fix(kqueue): replace .renamed events with .deleted as they are now equivalent --- src/backend/KQueue.zig | 2 +- src/backend/KQueueDir.zig | 4 ++-- src/types.zig | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/KQueue.zig b/src/backend/KQueue.zig index 8f3e717..7396bbf 100644 --- a/src/backend/KQueue.zig +++ b/src/backend/KQueue.zig @@ -175,7 +175,7 @@ fn thread_fn(self: *@This(), allocator: std.mem.Allocator) void { // skipped by scan_dir's snapshots.contains() check. self.remove_watch(allocator, dir_path); } else if (ev.fflags & NOTE_RENAME != 0) { - self.handler.change(dir_path, EventType.renamed, .dir) catch |e| { + self.handler.change(dir_path, EventType.deleted, .dir) catch |e| { std.log.err("nightwatch: handler returned {s}, stopping watch thread", .{@errorName(e)}); return; }; diff --git a/src/backend/KQueueDir.zig b/src/backend/KQueueDir.zig index ca95d63..4028ae2 100644 --- a/src/backend/KQueueDir.zig +++ b/src/backend/KQueueDir.zig @@ -136,7 +136,7 @@ fn thread_fn(self: *@This(), allocator: std.mem.Allocator) void { return; }; } else if (ev.fflags & NOTE_RENAME != 0) { - self.handler.change(watch_path, EventType.renamed, .file) catch |e| { + self.handler.change(watch_path, EventType.deleted, .file) catch |e| { std.log.err("nightwatch: handler returned {s}, stopping watch thread", .{@errorName(e)}); return; }; @@ -156,7 +156,7 @@ fn thread_fn(self: *@This(), allocator: std.mem.Allocator) void { // skipped by scan_dir's snapshots.contains() check. self.remove_watch(allocator, watch_path); } else if (ev.fflags & NOTE_RENAME != 0) { - self.handler.change(watch_path, EventType.renamed, .dir) catch |e| { + self.handler.change(watch_path, EventType.deleted, .dir) catch |e| { std.log.err("nightwatch: handler returned {s}, stopping watch thread", .{@errorName(e)}); return; }; diff --git a/src/types.zig b/src/types.zig index cf5695b..507211f 100644 --- a/src/types.zig +++ b/src/types.zig @@ -33,7 +33,7 @@ pub const EventType = enum { /// destination side. /// /// - **kqueue / kqueuedir**: when a watched *directory* is itself - /// renamed, a `renamed` change event is emitted for the old directory + /// renamed, a `deleted` change event is emitted for the old directory /// path (the new path is not known). Renames of *files inside* a /// watched directory are detected indirectly via directory-level /// `NOTE_WRITE` events and appear as `deleted` + `created`.