neurocyte/nightwatch
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(kqueue): replace .renamed events with .deleted as they are now equivalent

Browse source
This commit is contained in:
CJ van den Berg 2026-03-30 21:55:35 +02:00
parent 7171ad1905
commit b99d0e57a6
Signed by: neurocyte
GPG key ID: 8EB1E1BB660E3FB9
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/backend/KQueue.zig
View file

@ -175,7 +175,7 @@ fn thread_fn(self: *@This(), allocator: std.mem.Allocator) void {
// skipped by scan_dir's snapshots.contains() check. // skipped by scan_dir's snapshots.contains() check.
self.remove_watch(allocator, dir_path); self.remove_watch(allocator, dir_path);
} else if (ev.fflags & NOTE_RENAME != 0) { } else if (ev.fflags & NOTE_RENAME != 0) {
self.handler.change(dir_path, EventType.renamed, .dir) catch |e| { self.handler.change(dir_path, EventType.deleted, .dir) catch |e| {
std.log.err("nightwatch: handler returned {s}, stopping watch thread", .{@errorName(e)}); std.log.err("nightwatch: handler returned {s}, stopping watch thread", .{@errorName(e)});
return; return;
}; };

4
src/backend/KQueueDir.zig
View file

@ -136,7 +136,7 @@ fn thread_fn(self: *@This(), allocator: std.mem.Allocator) void {
return; return;
}; };
} else if (ev.fflags & NOTE_RENAME != 0) { } else if (ev.fflags & NOTE_RENAME != 0) {
self.handler.change(watch_path, EventType.renamed, .file) catch |e| { self.handler.change(watch_path, EventType.deleted, .file) catch |e| {
std.log.err("nightwatch: handler returned {s}, stopping watch thread", .{@errorName(e)}); std.log.err("nightwatch: handler returned {s}, stopping watch thread", .{@errorName(e)});
return; return;
}; };
@ -156,7 +156,7 @@ fn thread_fn(self: *@This(), allocator: std.mem.Allocator) void {
// skipped by scan_dir's snapshots.contains() check. // skipped by scan_dir's snapshots.contains() check.
self.remove_watch(allocator, watch_path); self.remove_watch(allocator, watch_path);
} else if (ev.fflags & NOTE_RENAME != 0) { } else if (ev.fflags & NOTE_RENAME != 0) {
self.handler.change(watch_path, EventType.renamed, .dir) catch |e| { self.handler.change(watch_path, EventType.deleted, .dir) catch |e| {
std.log.err("nightwatch: handler returned {s}, stopping watch thread", .{@errorName(e)}); std.log.err("nightwatch: handler returned {s}, stopping watch thread", .{@errorName(e)});
return; return;
}; };

2
src/types.zig
View file

@ -33,7 +33,7 @@ pub const EventType = enum {
/// destination side. /// destination side.
/// ///
/// - **kqueue / kqueuedir**: when a watched *directory* is itself /// - **kqueue / kqueuedir**: when a watched *directory* is itself
/// renamed, a `renamed` change event is emitted for the old directory /// renamed, a `deleted` change event is emitted for the old directory
/// path (the new path is not known). Renames of *files inside* a /// path (the new path is not known). Renames of *files inside* a
/// watched directory are detected indirectly via directory-level /// watched directory are detected indirectly via directory-level
/// `NOTE_WRITE` events and appear as `deleted` + `created`. /// `NOTE_WRITE` events and appear as `deleted` + `created`.